Fix wasm SQLite streaming statement lifetime#37
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a lifetime bug in WASM-backed SQLite streaming by ensuring prepared statements remain alive for the entire duration of streamed iteration, preventing dropped rows and iterator lifetime failures. It also enables streaming coverage for the SqlJsDialect in the WASM dialect test suite.
Changes:
- Replace the prior “prepare + return iterator” pattern with
iterateWithStatement(...)so statement cleanup happens only after iteration completes (or is closed) insqljsandofficial-wasm. - Stop using the transient
runWithStatementfor streaming paths (while keeping it for non-streaming query execution where appropriate). - Enable the shared streaming test for
sql.jsby removing thesupportStream=falseoverride.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/dialect-wasm/test/index.test.ts | Enables streaming coverage for SqlJsDialect by using the default streaming-enabled testCase behavior. |
| packages/dialect-wasm/src/dialects/sqljs.ts | Introduces iterateWithStatement generator to keep sql.js statements alive until iteration completes, then frees them. |
| packages/dialect-wasm/src/dialects/official-wasm.ts | Introduces iterateWithStatement generator to keep sqlite-wasm prepared statements alive until iteration completes, then finalizes them. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
sql.jsso sql.js gets the same streaming coverage as other wasm dialects.Description
iterateWithStatementhelper that prepares the statement, binds parameters, yields rows via a dedicatediteratorgenerator, and only frees/finalizes the statement after iteration completes insqljsandofficial-wasmdialects.runWithStatementfor streaming paths and instead return an iterator that keeps the statement alive for the full stream lifetime.runWithStatementdeclaration fromsqljs.tsto satisfy type checks.SqlJsDialectby removing thesupportStream=falseoverride in the wasm tests.Testing
pnpm test, which executed the test suite and reportedTest Files 5 passed (5)andTests 10 passed (10).pnpm typecheck && pnpm lint, which completed successfully (no TypeScript or lint errors).Codex Task